fix: #6312 #6346 Tailwind classes for inputswitch and checkbox as styling is broken #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
@melloware The tests are failing on issues that are not related to this PR. |
melloware
approved these changes
Apr 9, 2024
melloware
force-pushed
the
bugfix/fix-tailwind-inputswitch-checkbox
branch
from
5b80c96 to
cb03934
Compare
|
Agreed thanks for the PR! |
… currently broken - Update the tailwinddoc.js files for checkbox and inputswitch
melloware
force-pushed
the
bugfix/fix-tailwind-inputswitch-checkbox
branch
from
cb03934 to
d3ea9fb
Compare
This was referenced May 21, 2024
|
@gcko it looks like RadioButton needs the same fix for Tailwind? Any interest in a PR? |
|
I’ll take a look at it
Best,
Jared Scott
Founder | Variable
+1 (562) 302-8063
+886966463236
…________________________________
From: Melloware ***@***.***>
Sent: Friday, August 9, 2024 8:31:23 PM
To: primefaces/primereact ***@***.***>
Cc: Jared Scott ***@***.***>; Mention ***@***.***>
Subject: Re: [primefaces/primereact] fix: #6312 #6346 Tailwind classes for inputswitch and checkbox as styling is broken (PR #6347)
@gcko<https://github.com/gcko> it looks like RadioButton needs the same fix for Tailwind? Any interest in a PR?
—
Reply to this email directly, view it on GitHub<#6347 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD7NR5WIVFAWQDT4GGUNI3ZQSZBXAVCNFSM6AAAAABF6MXDZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXHA2DAMBVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6312
Fix #6346
Currently, Tailwind classes for inputswitch and checkbox as styling is broken. A user is also unable to interact with an
inputswitchcomponent using the provided default styles. This commit fixes that issue as well as the styling issues